-
Notifications
You must be signed in to change notification settings - Fork 48
Comparing changes
Open a pull request
base repository: apache/pulsar-client-python
base: main
head repository: apache/pulsar-client-python
compare: branch-3.4
- 7 commits
- 11 files changed
- 2 contributors
Commits on Dec 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c015418 - Browse repository at this point
Copy the full SHA c015418View commit details
Commits on Dec 20, 2023
-
Fix incorrect python spec name for release wheels workflow (#177)
There is an error when building the wheel for python12: ``` Dockerfile:35 -------------------- 33 | ENV PYTHON_LIBRARIES /opt/python/${PYTHON_SPEC}/lib/python${PYTHON_VERSION} 34 | 35 | >>> RUN pip3 install pyyaml 36 | 37 | ADD .build/dependencies.yaml / -------------------- ``` More context: https://github.com/apache/pulsar-client-python/actions/runs/7246274042/job/19737879474#step:6:237 The python spec name is incorrect in the github release wheels workflow. These are all specs in the manylinux2014: ``` [root@82c96c919b6f /]# cd /opt/python/ [root@82c96c919b6f python]# ll total 0 lrwxrwxrwx 1 root root 30 Dec 18 19:58 cp310-cp310 -> /opt/_internal/cpython-3.10.13 lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp311-cp311 -> /opt/_internal/cpython-3.11.7 lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp312-cp312 -> /opt/_internal/cpython-3.12.1 lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp36-cp36m -> /opt/_internal/cpython-3.6.15 lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp37-cp37m -> /opt/_internal/cpython-3.7.17 lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp38-cp38 -> /opt/_internal/cpython-3.8.18 lrwxrwxrwx 1 root root 29 Dec 18 19:57 cp39-cp39 -> /opt/_internal/cpython-3.9.18 lrwxrwxrwx 1 root root 33 Dec 18 19:58 pp310-pypy310_pp73 -> /opt/_internal/pp310-pypy310_pp73 lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp37-pypy37_pp73 -> /opt/_internal/pp37-pypy37_pp73 lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp38-pypy38_pp73 -> /opt/_internal/pp38-pypy38_pp73 lrwxrwxrwx 1 root root 31 Dec 18 19:58 pp39-pypy39_pp73 -> /opt/_internal/pp39-pypy39_pp73 ``` This PR fixes the incorrect spec name for python12. (cherry picked from commit bf8524a)Configuration menu - View commit details
-
Copy full SHA for 12d258c - Browse repository at this point
Copy the full SHA 12d258cView commit details
Commits on Dec 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0ca9f3c - Browse repository at this point
Copy the full SHA 0ca9f3cView commit details
Commits on Dec 26, 2023
-
Fix negative acknowledge on a message ID does not work (#180)
Fixes #178 ### Motivation #121 introduces a regression that when `negative_acknowledge` accepts a message ID, the underlying `acknowledgeAsync` method will be called. ### Modifications Fix the `Consumer_negative_acknowledge_message_id` method and add the test for negative acknowledging message IDs in `test_redelivery_count`. (cherry picked from commit b9c7219)
Configuration menu - View commit details
-
Copy full SHA for 8995f4a - Browse repository at this point
Copy the full SHA 8995f4aView commit details -
Fix windows release CI doesn't show the python version (#182)
(cherry picked from commit e667570)
Configuration menu - View commit details
-
Copy full SHA for a21fe46 - Browse repository at this point
Copy the full SHA a21fe46View commit details -
Fix missing dependency of setuptools (#183)
## Motivation There are some errors blocking the CI: https://github.com/apache/pulsar-client-python/actions/runs/7321925272/job/19942911045?pr=181 https://github.com/apache/pulsar-client-python/actions/runs/7320564743/job/19942264377 The python 3.12 has removed the setuptools for the default dependency by this PR: python/cpython#95299 > [gh-95299](python/cpython#95299): Do not pre-install setuptools in virtual environments created with [venv](https://docs.python.org/3/library/venv.html#module-venv). This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the [activated](https://docs.python.org/3/library/venv.html#venv-explanation) virtual environment. ## Verification Verification CI: https://github.com/apache/pulsar-client-python/actions/runs/7325997832 The result of CI shows that this fix could build the release wheel file successfully. (cherry picked from commit eafc672)
Configuration menu - View commit details
-
Copy full SHA for cfe55b4 - Browse repository at this point
Copy the full SHA cfe55b4View commit details -
Fix the incompatibility with Python 3.12 and drop the support for 3.7 (…
…#181) ### Motivation The `avro` component cannot be installed with Python 3.12 because the depended `fastavro` dependency is 1.7.3, which is not compatible with Python 3.12. However, the newer fastavro dependencies all do not support Python 3.7, which has already reached the EOL (2023-06-27). ### Modifications - Upgrade the fastavro dependency to 1.9.2 - Add the workflows to run tests for the lowest and highest supported Python versions (3.8 and 3.12). - Fix the documents (cherry picked from commit daabc67)
Configuration menu - View commit details
-
Copy full SHA for 5e5ba62 - Browse repository at this point
Copy the full SHA 5e5ba62View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...branch-3.4