Fix a null ACK grouping tracker can be accessed after consumer is closed #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #516
Motivation
#490 changes the ack tracker's behavior by flushing the pending requests when the object is destructed (via calling
shared_ptr::reset). However, it could expose the null pointer to other methods likeacknowledge.Modifications
Forbid resetting the ack grouping tracker by making it a
constfield ofConsumerImpl. After the consumer is Closing, prevent any new ACK request by failing it withResultAlreadyClosed. ThedoImmediateAckmethods are moved toConsumerImplso that we can just hold a weak reference toConsumerImplfor state check and ack flush.