-
Notifications
You must be signed in to change notification settings - Fork 76
[improve] modify the negativeACK structure to reduce memory overhead #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you fix the |
Contributor
Author
Of course, I'll deal with this. |
BewareMyPower
approved these changes
Aug 4, 2025
arhoads
reviewed
Aug 13, 2025
This was referenced Aug 20, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main content of this PR is to implement the Pulsar Java community's PIP-393 proposal in the CPP client.
Negative acknowledgement handling in now Pulsar CPP client exhibits inefficiencies related to memory usage, timing precision, and batch-level contention.
This effort aims to bring parity with the refinements implemented in the Java client, notably around memory usage and redelivery coordination.
Modifications
Refactor the
NegativeAcksTrackerto solve the above problems.Updated outdated images in CI:
Verifying this change
This change added tests and can be verified as follows:
testNegativeAcks)testNegativeAckPrecisionBitCnt.Documentation
doc-requireddoc-not-neededdocdoc-complete