Fix TableView's existing key-value will never be updated #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486
Motivation
The
emplacemethod ofSynchronizedHashMapadopts the same semantics as https://en.cppreference.com/w/cpp/container/map/emplace, which inserts the key-value only when the key does not exist.TableViewImplleverages this method to update the key-values, so it will never succeed. In addition, this method is not thread safe because if the key exists, an iterator will be returned to the caller, then the caller could use the iterator to modify the value without any synchronization.Modifications
Add two new methods
putIfAbsentandputand remove theemplacemethod.putIfAbsent: inserts the key-value only when the key does not exist and return the optional existing valueput: inserts the key-value no matter if the key exists.Then, replace the
emplacecall withputinTableViewImpl.Verifying this change
testSimpleTableViewis improved to verify the update case.