fix: ignore ping command in connection keepalive logic #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479
Motivation
The current keepalive logic is too lenient – merely receiving ping commands can keep the connection alive.
Modifications
Ignore ping command in connection keepalive logic.
Verifying this change
This change is a trivial rework without any test coverage. It is not easy to write a test for ClientConnection but the change is simple.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededBug fix only.
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)