Skip to content

Conversation

@arhoads
Copy link
Contributor

@arhoads arhoads commented Oct 22, 2024

Fixes: Default operation timeout has the wrong value (no issue entered)

Motivation

The driver will timeout on all operations because the operation timeout is initialized with a literal of a too small size and when cast to std::chrono::seconds we end up with 0. long long should be used because according to https://en.cppreference.com/w/cpp/chrono/duration std::chrono::nanoseconds takes a type of at least 64 bits.

Example of the problem here:
https://godbolt.org/z/o51G6xbqo

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@BewareMyPower BewareMyPower added the bug Something isn't working label Oct 26, 2024
@BewareMyPower BewareMyPower added this to the 3.7.0 milestone Oct 26, 2024
@BewareMyPower
Copy link
Contributor

There seems to be something wrong with the CI, I will take a look next week

@BewareMyPower
Copy link
Contributor

@arhoads Could you rebase to the latest main branch, which has fixed the CI?

@shibd shibd merged commit 3efa80a into apache:main Oct 31, 2024
16 checks passed
@arhoads arhoads deleted the fix-default-operation-timeout branch October 31, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants