Use Rocky Linux 8 and vcpkg to build RPM packages #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This patch has been verified in my own fork, see BewareMyPower#32 (comment) |
merlimat
approved these changes
Jun 24, 2024
RobertIndie
reviewed
Jun 24, 2024
shibd
approved these changes
Jun 24, 2024
RobertIndie
approved these changes
Jun 24, 2024
2 tasks
shibd
pushed a commit
to shibd/pulsar-client-cpp
that referenced
this pull request
Aug 21, 2024
### Motivation See https://lists.apache.org/thread/7o8hpv1gtoffvzx053wm0ss2s9xt0795, we will discard the support for CentOS 7 and old `std::string` ABI. ### Modifications - Switch from `centos:7` image and GCC 4.8 to `rockylinux:8` image and GCC 8 to build RPM packages. - Use vcpkg to install dependencies according to `vcpkg.json` (`dependencies.json` will be deprecated in future) - Add a new script to build `libpulsarwithdeps.a` for dependencies installed by vcpkg - Link to `libstdc++` and `libgcc_s` libraries statically Additional, with vcpkg, OpenSSL will search `/etc/ssl/certs.pem` for the default CA certificate rather than `/usr/local/ssl/ssl/certs.pem`. (cherry picked from commit 8aab896)
shibd
pushed a commit
to shibd/pulsar-client-cpp
that referenced
this pull request
Aug 21, 2024
### Motivation See https://lists.apache.org/thread/7o8hpv1gtoffvzx053wm0ss2s9xt0795, we will discard the support for CentOS 7 and old `std::string` ABI. ### Modifications - Switch from `centos:7` image and GCC 4.8 to `rockylinux:8` image and GCC 8 to build RPM packages. - Use vcpkg to install dependencies according to `vcpkg.json` (`dependencies.json` will be deprecated in future) - Add a new script to build `libpulsarwithdeps.a` for dependencies installed by vcpkg - Link to `libstdc++` and `libgcc_s` libraries statically Additional, with vcpkg, OpenSSL will search `/etc/ssl/certs.pem` for the default CA certificate rather than `/usr/local/ssl/ssl/certs.pem`. (cherry picked from commit 8aab896)
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://lists.apache.org/thread/7o8hpv1gtoffvzx053wm0ss2s9xt0795, we will discard the support for CentOS 7 and old
std::stringABI.Modifications
centos:7image and GCC 4.8 torockylinux:8image and GCC 8 to build RPM packages.vcpkg.json(dependencies.jsonwill be deprecated in future)libpulsarwithdeps.afor dependencies installed by vcpkglibstdc++andlibgcc_slibraries staticallyAdditional, with vcpkg, OpenSSL will search
/etc/ssl/certs.pemfor the default CA certificate rather than/usr/local/ssl/ssl/certs.pem.