Support seek operation on a multi-topics consumer #426
Conversation
### Motivation See apache/pulsar-client-python#213 ### Modifications Add a new `forEachValue` overload that allows users to count the number of rest running tasks through `SharedFuture` to `SynchronizedHashMap`. Leverage this overload in seek operations when the argument is a timestamp, or a MessageId that represents earliest or latest. When the argument is a MessageId whose `getTopicName()` method returns a correct topic name, seek on the internal consumer of that topic. Add `testMultiTopicsSeekAll` and `testMultiTopicsSeekSingle` to `ConsumerSeekTest` to cover these cases.
| } | ||
| }); | ||
| }, | ||
| [callback] { callback(ResultOk); }); |
There was a problem hiding this comment.
If there are no consumers, it means no cursor will be reset. Maybe we cannot return a ResultOk.
There was a problem hiding this comment.
Actually I agree with you but here it just keeps the same behavior with the Java client. See the original implementation from apache/pulsar#7518
There was a problem hiding this comment.
We can start a discussion, or we should add a WARN log on here.
Otherwise, when something goes wrong, it's hard to troubleshoot.
There was a problem hiding this comment.
The Java client does not have a warn log here as well. You can start a discussion in dev ML. But it should not block this PR because this PR keeps the same behavior with the Java client.
There was a problem hiding this comment.
@shibd I make the seek call fail with ResultOperationNotSupported with a error log now. PTAL again.
The discussion mail: https://lists.apache.org/thread/qrwvl1zshmdohphjtdyp9v98hdngxb30
|
According to Zike's comment in the discussion in the mail list: https://lists.apache.org/thread/qrwvl1zshmdohphjtdyp9v98hdngxb30 So I reverted the change and only retained the test. PTAL again @shibd @RobertIndie |
3 participants
Motivation
See apache/pulsar-client-python#213
Modifications
Add a new
forEachValueoverload that allows users to count the number of rest running tasks throughSharedFuturetoSynchronizedHashMap. Leverage this overload in seek operations when the argument is a timestamp, or a MessageId that represents earliest or latest. When the argument is a MessageId whosegetTopicName()method returns a correct topic name, seek on the internal consumer of that topic.Add
testMultiTopicsSeekAllandtestMultiTopicsSeekSingletoConsumerSeekTestto cover these cases.