[feat] Add startPaused setting to consumer #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The 3.5.0 candidate 2 is in vote, do you want to include this PR in this release? Or is it acceptable to delay it to 3.6.0? |
Contributor
Author
|
@BewareMyPower Oh, I missed it. Changed the milestone to 3.6.0. |
tests/BasicEndToEndTest.cc
Outdated
| std::this_thread::sleep_for(std::chrono::microseconds(2 * 1000 * 1000)); | ||
| ASSERT_EQ(globalCount, 0); | ||
| consumer.resumeMessageListener(); | ||
| std::this_thread::sleep_for(std::chrono::microseconds(2 * 1000 * 1000)); |
Contributor
There was a problem hiding this comment.
Use waitUntil to avoid sleeping too long, see examples in tests/ProducerTest.cc
Contributor
Author
There was a problem hiding this comment.
Replaced the second sleep with waitUntil. Replacing the first one would be difficult.
BewareMyPower
approved these changes
Mar 14, 2024
shibd
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Java client consumer has a setting called
startPaused. If this is set to true, the created consumer will not fetch messages from the broker until resume is called. Currently, this setting does not seem to exist in the C++ client consumer, so I will add it.Verifying this change
Documentation
doc-not-needed