Install Version.h when installing by CMakeLists #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation The macOS pre-built binaries don't include the Version.h generated from CMake. It's because `cmake --target install` does not install the `Version.h`, which is generated by `configure_file`. ### Modifications Install the `Version.h`.
merlimat
approved these changes
Dec 4, 2023
shibd
approved these changes
Dec 4, 2023
BewareMyPower
added a commit
that referenced
this pull request
Dec 6, 2023
### Motivation The macOS pre-built binaries don't include the Version.h generated from CMake. It's because `cmake --target install` does not install the `Version.h`, which is generated by `configure_file`. ### Modifications Install the `Version.h`. (cherry picked from commit 751c807)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The macOS pre-built binaries don't include the Version.h generated from CMake. It's because
cmake --target installdoes not install theVersion.h, which is generated byconfigure_file.Modifications
Install the
Version.h.