Remove log4cxx dependency and its specified configuration #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation See apache/pulsar#1827, which also marked the log4cxx configurations as deprecated. ### Modifications Remove all log4cxx related stuff. log4cxx users can implement their own `LoggerFactory` like the built-in implementation before this PR.
BewareMyPower
requested review from
Demogorgon314,
RobertIndie,
merlimat and
shibd
shibd
approved these changes
Jun 13, 2023
Member
|
This is a breaking change, and it fails the Python client build when using the main branch of cpp client. |
Contributor
Author
|
Yes, we should also remove the configs from Python as well. |
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Aug 11, 2023
### Modifications Upgrade the C++ client to 3.3.0 and deprecate the `log_conf_file_path` config due to apache/pulsar-client-cpp#283. There is another issue that after apache/pulsar-client-cpp#290, the CMakeLists.txt from the C++ client finds the protobuf package with config mode. To fix it, install the OpenSSL via CMake instead of the autotools.
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Aug 11, 2023
### Modifications Upgrade the C++ client to 3.3.0 and deprecate the `log_conf_file_path` config due to apache/pulsar-client-cpp#283. There is another issue that after apache/pulsar-client-cpp#290, the CMakeLists.txt from the C++ client finds the protobuf package with config mode. To fix it, install the OpenSSL via CMake instead of the autotools.
BewareMyPower
added a commit
to apache/pulsar-client-python
that referenced
this pull request
Aug 11, 2023
### Modifications Upgrade the C++ client to 3.3.0 and deprecate the `log_conf_file_path` config due to apache/pulsar-client-cpp#283. There is another issue that after apache/pulsar-client-cpp#290, the CMakeLists.txt from the C++ client finds the protobuf package with config mode. To fix it, install the OpenSSL via CMake instead of the autotools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See apache/pulsar#1827, which also marked the log4cxx configurations as deprecated.
Modifications
Remove all log4cxx related stuff. log4cxx users can implement their own
LoggerFactorylike the built-in implementation before this PR.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)