Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/pulsar-client-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.4.1
Choose a base ref
...
head repository: apache/pulsar-client-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.4.2
Choose a head ref
  • 6 commits
  • 22 files changed
  • 1 contributor

Commits on Dec 6, 2023

  1. Gather the macOS binaries when releasing (#355) 

    (cherry picked from commit 0bbc155)
    @BewareMyPower
    BewareMyPower committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    478d3c3 View commit details
    Browse the repository at this point in the history

  2. Fix HTTP lookup segfault when the redirect host cannot be resolved (#356 

    )

### Motivation

When the host of the redirect URL cannot be resolved, segmentation fault
will happen:
https://github.com/apache/pulsar-client-cpp/blob/0bbc15502905d19c630d237b5e102bfb996bb098/lib/CurlWrapper.h#L173-L175

In this case, `curl` will be `nullptr`. Assigning a nullptr to a
`std::string` is an undefined behavior that might cause segfault.

### Modifications

Check if `url` is nullptr in `CurlWrapper::get` and before assigning it
to the `redirectUrl` field. Improve the
`HTTPLookupService::sendHTTPRequest` method by configuring the
`maxLookupRedirects` instead of a loop and print more detailed error
messages.

(cherry picked from commit d209482)
    @BewareMyPower
    BewareMyPower committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6192987 View commit details
    Browse the repository at this point in the history

  3. Install Version.h when installing by CMakeLists (#361) 

    ### Motivation

The macOS pre-built binaries don't include the Version.h generated from
CMake. It's because `cmake --target install` does not install the
`Version.h`, which is generated by `configure_file`.

### Modifications

Install the `Version.h`.

(cherry picked from commit 751c807)
    @BewareMyPower
    BewareMyPower committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    8595f97 View commit details
    Browse the repository at this point in the history

  4. Fix accessing destroyed objects in the callback of async_wait (#362) 

    Fixes #358
Fixes #359

### Motivation

`async_wait` is not used correctly in some places. A callback that
captures the `this` pointer or reference to `this` is passed to
`async_wait`, if this object is destroyed when the callback is called,
an invalid memory access will happen.

### Modifications

Use the following pattern in all `async_wait` calls.

```c++
std::weak_ptr<T> weakSelf{shared_from_this()};
timer_->async_wait([weakSelf](/* ... */) {
    if (auto self = weakSelf.lock()) {
        self->foo();
    }
});
```

(cherry picked from commit 24ab12c)
    @BewareMyPower
    BewareMyPower committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6cb391a View commit details
    Browse the repository at this point in the history

  5. Fix tlsTrustCertsFilePath config is not applied for OAuth2 (#364) 

    ### Motivation

#313 has reverted the
fix of #190, which
applies the `tlsTrustCertsFilePath` config for OAuth2 authentication.

The macOS pre-built libraries are affected most because the bundled CA
path is empty.

### Modification

Apply the `tlsTrustCertsFilePath` for OAuth2.

(cherry picked from commit 27cba3e)
    @BewareMyPower
    BewareMyPower committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    afe54da View commit details
    Browse the repository at this point in the history

  6. Release 3.4.2

    @BewareMyPower
    BewareMyPower committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    1cb1bf8 View commit details
    Browse the repository at this point in the history
Loading