Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/pulsar-client-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: apache/pulsar-client-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: branch-3.5
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 9 files changed
  • 2 contributors

Commits on Mar 1, 2024

  1. Release 3.5.0

    @BewareMyPower
    BewareMyPower committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3b574c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge branch 'main' into branch-3.5

    @BewareMyPower
    BewareMyPower committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    916af95 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Support customize vcpkg directory when INTEGRATE_VCPKG is ON (#417) 

    ### Motivation

Currently when INTEGRATE_VCPKG is ON, the CMAKE_TOOLCHAIN_FILE variable
is always a subdirectory of `${CMAKE_SOURCE_DIR}/vcpkg`. We can only
customize the vcpkg directory when INTEGRATE_VCPKG is OFF, while the
legacy CMake logic is incompatible with this way.

### Modifications

When INTEGRATE_VCPKG is ON, only set CMAKE_TOOLCHAIN_FILE if it's not
defined. The workflow and README are updated for it.

(cherry picked from commit 8218717)
    @BewareMyPower
    BewareMyPower committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e7793d6 View commit details
    Browse the repository at this point in the history

  2. Fix broken wireshark build workflow on macOS (#414) 

    ### Motivation

See https://github.com/apache/pulsar-client-cpp/actions/runs/8276076995/job/22644077705

```
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
```

`brew install` failed because the wireshark dependency depends on
python@3.12 and it failed at `brew link`.

### Modifications

Remove the existing binaries that might conflict.

(cherry picked from commit c513f29)
    @BewareMyPower
    BewareMyPower committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0e0ca8d View commit details
    Browse the repository at this point in the history

  3. Fix minor issues reported by CodeQL (#421) 

    (cherry picked from commit 763b85c)
    @merlimat @BewareMyPower
    merlimat authored and BewareMyPower committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    7cfd775 View commit details
    Browse the repository at this point in the history

  4. Fix wrong results of hasMessageAvailable and readNext after seeking b… 

    …y timestamp (#422)

Fixes #420

It's a catch-up for apache/pulsar#22363

(cherry picked from commit 27d8cc0)
    @BewareMyPower
    BewareMyPower committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    b2ad352 View commit details
    Browse the repository at this point in the history

  5. Release 3.5.1

    @BewareMyPower
    BewareMyPower committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0ba3d7d View commit details
    Browse the repository at this point in the history
Loading