[fix][broker] Apply dedup disable after recovery#25982
Open
Denovo1998 wants to merge 1 commit into
Open
Conversation
dao-jun
approved these changes
Jun 9, 2026
merlimat
approved these changes
Jun 10, 2026
void-ptr974
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Message deduplication recovery now returns the active recovery future when another
checkStatus()call observesRecovering. However, if the topic policy changes to disable deduplication while recovery is still in progress, the second check only waits for the recovery future and does not apply the new disabled target state.As a result, recovery can complete as
Enabled, leaving deduplication active until another status check happens.Modifications
Failedstatus as well asEnabled.Verifying this change
./gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.BrokerMessageDeduplicationTest --rerun-tasksDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes