Skip to content

PARQUET-1669: Disable compiling all libraries when building thrift - #688

Merged
gszadovszky merged 1 commit into
apache:masterfrom
sekikn:PARQUET-1669
Oct 2, 2019
Merged

gszadovszky merged 1 commit into
apache:masterfrom
sekikn:PARQUET-1669

Conversation

@sekikn

@sekikn sekikn commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

No additional test since it's a fix for the CI script. I confirmed that all CI jobs succeeded and each job saved about 3 minutes using my Travis account.

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@gszadovszky
gszadovszky merged commit 600ffba into apache:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants