Ambiguous project name changed to python3ActionLoop #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngeloDanducci
changed the title
rabbah
approved these changes
Sep 22, 2020
Member
|
Thanks for the fix and the nudge in slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR to get the discussion rolling. Master builds of have been completing with a status of errored due to:
The error stems from the ${RUNTIME} argument in the gradle command in the publish.sh script being ambiguous.
https://github.com/apache/openwhisk-runtime-python/blob/master/tools/travis/publish.sh#L49
https://github.com/apache/openwhisk-runtime-python/blob/master/tools/travis/publish.sh#L58
I assume this should be python3ActionLoop and not 2 given Python 2's end of life and also the runtime version looking for 3-x in the rest of the arguments.