Updated ActionLoop Python Runtimes #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sciabarra
commented
Feb 7, 2020
sciabarra
commented
- using changes to the goproxy to support better error handling and better detection termination
- an actionloop based runtime for python2.7, python3.7 and python3.6 with AI (tensorflow)
sciabarra
changed the title
rabbah
approved these changes
Feb 15, 2020
Member
rabbah
left a comment
rabbah
left a comment
There was a problem hiding this comment.
This LGTM. Have you thought about reducing the repetition of the launcher, compiler and makefile?
rabbah
reviewed
Feb 15, 2020
tests/src/test/scala/runtime/actionContainers/PythonActionLoopExtraTests.scala
Show resolved
Hide resolved
Contributor
|
actually the various launcher and compiler have small differences so ... there is not really a repetition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.