Skip to content

remove Python 3.6 based runtime #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
style95 merged 1 commit into from
May 17, 2023
Merged

remove Python 3.6 based runtime #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ jobs:
SHORT_COMMIT=$(git rev-parse --short "$GITHUB_SHA")
./gradlew :core:python3Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
./gradlew :core:python3Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT
./gradlew :core:python36AiAction:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
./gradlew :core:python36AiAction:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT
Copy link
Member

@style95 style95 May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will entirely remove AI runtime.
I am not sure we need to archive it for future reference(though we can still refer to the commit).

Copy link
Member Author

@dgrove-oss dgrove-oss May 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I hesitated on this which is why I didn't remove this runtime back in early 2022 when we first hit the EOL date. But at this point, Python 3.6 is more than a year past its EOL and all of the AI libraries included in this image are also obsolete. So, I think this runtime is no longer useful to provide from the core project. There is enough diversity in Python packages for AI, that its also not clear to me that we can hope to provide the "one true" combination of packages as a core runtime (as opposed to people building custom images and running as a blackbox or as a python virtualenv).

Copy link
Member

@style95 style95 May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point.

./gradlew :core:python39Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
./gradlew :core:python39Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT
./gradlew :core:python310Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
Expand All @@ -106,8 +104,6 @@ jobs:
IMAGE_TAG=${GITHUB_REF_NAME##*@}
if [ ${RUNTIME_VERSION} == "3" ]; then
RUNTIME="python3Action"
elif [ ${RUNTIME_VERSION} == "3-ai" ]; then
RUNTIME="python36AiAction"
elif [ ${RUNTIME_VERSION} == "39" ]; then
RUNTIME="python39Action"
elif [ ${RUNTIME_VERSION} == "310" ]; then
Expand Down
3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,6 @@ others.
./gradlew :tests:test --tests Python*Tests
```

## Python 3 AI Runtime
This action runtime enables developers to create AI Services with OpenWhisk. It comes with preinstalled libraries useful for running Machine Learning and Deep Learning inferences. [Read more about this runtime here](./core/python36AiAction).

## Using additional python libraries

If you need more libraries for your Python action, you can include a virtualenv in the zip file of the action.
Expand Down
94 changes: 0 additions & 94 deletions core/python36AiAction/Dockerfile
View file
Open in desktop

This file was deleted.

85 changes: 0 additions & 85 deletions core/python36AiAction/README.md
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions core/python36AiAction/build.gradle
View file
Open in desktop

This file was deleted.

32 changes: 0 additions & 32 deletions core/python36AiAction/requirements.txt
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions core/python36AiAction/samples/smart-body-crop/.gitignore
View file
Open in desktop

This file was deleted.

Loading