Skip to content

Conversation

@dgrove-oss
Copy link
Member

Python 3.6 is past its end of life; therefore this runtime is no longer receiving security updates.

Python 3.6 is past its end of life; therefore this runtime is no
longer receiving security updates.
@dgrove-oss dgrove-oss requested a review from rabbah May 4, 2023 12:58
@dgrove-oss dgrove-oss requested a review from style95 May 15, 2023 17:48
Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor discussion point.

./gradlew :core:python3Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
./gradlew :core:python3Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT
./gradlew :core:python36AiAction:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
./gradlew :core:python36AiAction:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will entirely remove AI runtime.
I am not sure we need to archive it for future reference(though we can still refer to the commit).

Copy link
Member Author

@dgrove-oss dgrove-oss May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I hesitated on this which is why I didn't remove this runtime back in early 2022 when we first hit the EOL date. But at this point, Python 3.6 is more than a year past its EOL and all of the AI libraries included in this image are also obsolete. So, I think this runtime is no longer useful to provide from the core project. There is enough diversity in Python packages for AI, that its also not clear to me that we can hope to provide the "one true" combination of packages as a core runtime (as opposed to people building custom images and running as a blackbox or as a python virtualenv).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor discussion point.

@style95 style95 merged commit e507a01 into apache:master May 17, 2023
@dgrove-oss dgrove-oss deleted the drop-eol-versions branch May 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants