-
Notifications
You must be signed in to change notification settings - Fork 69
remove Python 3.6 based runtime #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Python 3.6 is past its end of life; therefore this runtime is no longer receiving security updates.
f1717b5 to
97d5463
Compare
style95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor discussion point.
| ./gradlew :core:python3Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly | ||
| ./gradlew :core:python3Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT | ||
| ./gradlew :core:python36AiAction:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly | ||
| ./gradlew :core:python36AiAction:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will entirely remove AI runtime.
I am not sure we need to archive it for future reference(though we can still refer to the commit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I hesitated on this which is why I didn't remove this runtime back in early 2022 when we first hit the EOL date. But at this point, Python 3.6 is more than a year past its EOL and all of the AI libraries included in this image are also obsolete. So, I think this runtime is no longer useful to provide from the core project. There is enough diversity in Python packages for AI, that its also not clear to me that we can hope to provide the "one true" combination of packages as a core runtime (as opposed to people building custom images and running as a blackbox or as a python virtualenv).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point.
style95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor discussion point.
Python 3.6 is past its end of life; therefore this runtime is no longer receiving security updates.