-
Notifications
You must be signed in to change notification settings - Fork 69
Add Python 3.10 runtime based on Python 3.9 runtime. #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rabbah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM do you mind also updating the travis file so we publish this image nighly as well?
Add Python 3.10
Add Python 3.10
|
Sure. I've done that now. I think my approach here is adding a lot of repeated code, but I saw that the current state of the repo already has code repeated this way (between 3.7 and 3.9) so I figured it wasn't a regression. In the future, maybe we could look for opportunities to DRY it. I saw the Node.js runtime repo DRY'd pretty well like this. Here, I'm sure there are opportunities like creating a base Dockerfile to use, since the only thing changing is the version of the base Python image used. Maybe we could try to DRY the code during a 3.11 release. Or, if you'd rather keep refactors separate from new features, it could be its own task. Another thing I think could be improved in the runtime, also either during a DRY refactor, or as its own new feature, is adding support for |
|
Something that still might be left to do is add support for the new "kind" since a new version of each programming language results in a new kind. I remember reading a guide a while ago about creating new runtimes and it mentioned adding your runtime to a list of kinds by updating a |
|
@mattwelke , after merged this pr into master, seems current master's travis ci's test cases failed: #132, and the test case failed only happened on
|
|
@ningyougang Sorry, I missed that when I was creating this PR. I originally did a custom 3.10 build by changing a few files in my fork and then using it. All local. It passed /init and /run no problem. This issue must have only applied to the way this repo was set up. Thanks for catching it. |
No description provided.