Support python39 #110
Closed
Support python39 #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
reviewed
Jul 6, 2021
Member
rabbah
left a comment
rabbah
left a comment
There was a problem hiding this comment.
This PR is also fixing a bug when __OW_EXECUTION_ENV is not defined and addressing venv activate on windows. It would be better if those were separated into their own PRs IMO but willing to merge them all at once.
- An akka upgrade in apache/openwhisk required changes here to successfully build and run the test cases. - fix fix taken from [openwhisk-runtime-docker 89](apache/openwhisk-runtime-docker#89)
Co-authored-by: rodric rabbah <rodric@gmail.com>
Co-authored-by: rodric rabbah <rodric@gmail.com>
rabbah
reviewed
Jul 8, 2021
tests/src/test/scala/runtime/actionContainers/Python39ctionLoopContainerTests.scala
Outdated
Show resolved
Hide resolved
rabbah
reviewed
Jul 9, 2021
rabbah
reviewed
Jul 11, 2021
Member
rabbah
left a comment
rabbah
left a comment
There was a problem hiding this comment.
LGTM but some of the "release" to "source" references will need to be changed back at some point when the go proxy is released.
sciabarracom
force-pushed
the
support-python39
branch
from
cc492a2 to
7bdec45
Compare
Contributor
Author
|
plase merge #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note support for requirements.txt requires an update to the goproxy
apache/openwhisk-runtime-go#148