{bp-19021} boards/lckfb-szpi-esp32s3: switch adb config to nxinit entrypoint#19087
Merged
Conversation
Replace the default nsh-based init flow on the lckfb-szpi-esp32s3 :adb defconfig with system/nxinit so that services (sh console, adbd) are spawned and reaped by init through /etc/init.d/init.rc. - Enable CONFIG_SYSTEM_NXINIT and set INIT_ENTRYPOINT to init_main (CONFIG_EXPERIMENTAL is required by SYSTEM_NXINIT). - Add a common init.rc under boards/xtensa/esp32s3/common/src/etc/init.d defining 'console' (sh) and 'adbd' services and starting both on init. fastbootd is wired in for completeness when configured. - Append the new init.rc to RCSRCS only when SYSTEM_NXINIT is enabled so existing nsh-based configs remain unaffected. Verified on lckfb-szpi-esp32s3 hardware: init_main spawns sh and adbd (both with PPID=init), 'adb shell' reaches a working NuttShell. Assisted-by: GitHubCopilot:claude-4.8-opus Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
jerpelea
requested review from
acassis,
cederom,
fdcavalcanti,
linguini1,
lupyuen and
xiaoxiang781216
lupyuen
approved these changes
Jun 10, 2026
xiaoxiang781216
approved these changes
Jun 10, 2026
github-actions
Bot
added
Size: S
fdcavalcanti
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the default nsh-based init flow on the lckfb-szpi-esp32s3 :adb defconfig with system/nxinit so that services (sh console, adbd) are spawned and reaped by init through /etc/init.d/init.rc.
Verified on lckfb-szpi-esp32s3 hardware: init_main spawns sh and adbd (both with PPID=init), 'adb shell' reaches a working NuttShell.
Assisted-by: GitHubCopilot:claude-4.8-opus
Impact
RELEASE
Testing
CI