Skip to content

tools: Fix esptool.py and espsecure.py warnning #16723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tools: Fix esptool.py and espsecure.py warnning #16723

wants to merge 2 commits into from

Conversation

@bl4kraven
Copy link
Contributor

@bl4kraven bl4kraven commented Jul 14, 2025

Hi,

Starting with esptool.py and espsecure.py v5.0.0, running esptool.py and espsecure.py pops up the warning:

Warning: DEPRECATED: 'esptool.py' is deprecated. Please use 'esptool' instead. The '.py' suffix will be removed in a future major release.

Warning: DEPRECATED: 'espsecure.py' is deprecated. Please use 'espsecure' instead. The '.py' suffix will be removed in a future major release.
The esptool project commit espressif/esptool@635cde1.

Testing

Test on esp32-devkitc.

@bl4kraven
tools: Replace esptool.py with esptool
674872c 
Starting with esptool.py v5.0.0, running esptool.py pops up the warning:
"Warning: DEPRECATED: 'esptool.py' is deprecated. Please use 'esptool'
instead. The '.py' suffix will be removed in a future major release."

Signed-off-by: Leo Chung <gewalalb@gmail.com>
@github-actions github-actions bot added Area: Tooling Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Size: S The size of the change in this PR is small labels Jul 14, 2025
@bl4kraven
xtensa|risc-v: Replace espsecure.py with espsecure for esp32[-|c3|s2]
fb43d95 
Starting with espsecure.py v5.0.0, running espsecure.py pops up the warning:
"Warning: DEPRECATED: 'espsecure.py' is deprecated. Please use 'espsecure'
instead. The '.py' suffix will be removed in a future major release."

Signed-off-by: Leo Chung <gewalalb@gmail.com>
@bl4kraven bl4kraven force-pushed the fix_esptool_warnning branch from f12f62d to fb43d95 Compare July 14, 2025 09:00
@eren-terzioglu
Copy link
Contributor

eren-terzioglu commented Jul 14, 2025 •
edited
Loading

Hi,
We are suggesting to use esptool 4.8.dev4. We didn't tested tihs version of esptool completely and currently we should suggest you to use our tested version of esptool. This change is a breaking change and it should be tested extensively and also has to be added into Dockerfile.

For other suggested development environment please check project's docker file.

@acassis
Copy link
Contributor

acassis commented Jul 14, 2025

@eren-terzioglu maybe it is a good idea to use esptool from distro, this is a competitive advantage. When working with STM32 for example we don't need to download anything from ST site.

Espressif is doing a great working adding support to OpenOCD for example. I think keeping the esptool on Linux updated is very important to users.

@acassis
Copy link
Contributor

acassis commented Jul 14, 2025

Hi, We are suggesting to use esptool 4.8.dev4. We didn't tested tihs version of esptool completely and currently we should suggest you to use our tested version of esptool. This change is a breaking change and it should be tested extensively and also has to be added into Dockerfile.

For other suggested development environment please check project's docker file.

Maybe the Dockerfile is using an outdated esptool version or doesn't have it installed.

@eren-terzioglu
Copy link
Contributor

eren-terzioglu commented Jul 14, 2025

@eren-terzioglu maybe it is a good idea to use esptool from distro, this is a competitive advantage. When working with STM32 for example we don't need to download anything from ST site.

Espressif is doing a great working adding support to OpenOCD for example. I think keeping the esptool on Linux updated is very important to users.

Even if this change is better, we need to test it completely. Please don't merge it for a while.

@fdcavalcanti
Copy link
Contributor

fdcavalcanti commented Jul 14, 2025

Please hold on for a second.

Updating esptool to v5.0 requires other things to be taken into consideration:

  • Anyone still running older esptool will have build issues, as their installation requires esptool.py. We would need some kind of build warning and a hint to those people that they MUST update their version.
  • On Espressif side, we have not even updated our CI with this new esptool, so there's no testing done.
  • All Espressif docs must be updated regarding esptool. As of now, the suggested version is still 4.9.1 (or something).

@acassis
Copy link
Contributor

acassis commented Jul 14, 2025

@eren-terzioglu maybe it is a good idea to use esptool from distro, this is a competitive advantage. When working with STM32 for example we don't need to download anything from ST site.
Espressif is doing a great working adding support to OpenOCD for example. I think keeping the esptool on Linux updated is very important to users.

Even if this change is better, we need to test it completely. Please don't merge it for a while.

Sure, it needs more tests

@eren-terzioglu
Copy link
Contributor

eren-terzioglu commented Jul 14, 2025

Hi, We are suggesting to use esptool 4.8.dev4. We didn't tested tihs version of esptool completely and currently we should suggest you to use our tested version of esptool. This change is a breaking change and it should be tested extensively and also has to be added into Dockerfile.
For other suggested development environment please check project's docker file.

Maybe the Dockerfile is using an outdated esptool version or doesn't have it installed.

Dockerfile version is the version that we are using currently

@acassis
Copy link
Contributor

acassis commented Jul 14, 2025

@bl4kraven please consider @eren-terzioglu and @bl4kraven and if you can please help, after they confirm everything works, please help updating the Documentation.

@bl4kraven
Copy link
Contributor Author

bl4kraven commented Jul 14, 2025

OK, if everything test ok, i will update the documentation.

tmedicci
tmedicci requested changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@tmedicci tmedicci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged before updating CI's esptool version at tools/ci/docker/linux/Dockerfile.

Apart from that, from our side, extensive testing must be performed internally (cc @fdcavalcanti @eren-terzioglu ). Please don't merge it yet.

@fdcavalcanti fdcavalcanti mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmedicci tmedicci tmedicci requested changes

@acassis acassis acassis approved these changes

@jerpelea jerpelea jerpelea approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Arch: risc-v Issues related to the RISC-V (32-bit or 64-bit) architecture Arch: xtensa Issues related to the Xtensa architecture Area: Tooling Size: S The size of the change in this PR is small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bl4kraven @eren-terzioglu @acassis @fdcavalcanti @jerpelea @xiaoxiang781216 @tmedicci