Skip to content

Add Njord extension to ignored Maven lifecycle participants.#8641

Merged
neilcsmith-net merged 1 commit intoapache:masterfrom
neilcsmith-net:njord-ignore
Jul 15, 2025
Merged

Add Njord extension to ignored Maven lifecycle participants.#8641
neilcsmith-net merged 1 commit intoapache:masterfrom
neilcsmith-net:njord-ignore

Conversation

@neilcsmith-net
Copy link
Member

With the sunsetting of OSSRH the sensible(!) projects are switching to Njord to handle publishing to central. Unfortunately, if added as an extension in the POM, NetBeans adds a project warning that cannot be removed.

This is a quick fix for NB27 to add Njord to the ignore list. There may be other Maveniverse extensions that do not impact on NetBeans' Maven support that could be added too.

Longer term, we should improve user configuration here, and possibly a better UI for marking problems as ignored?

cc/ @cstamas

@neilcsmith-net neilcsmith-net added this to the NB27 milestone Jul 9, 2025
@neilcsmith-net neilcsmith-net requested a review from mbien July 9, 2025 10:52
@neilcsmith-net neilcsmith-net added the Maven [ci] enable "build tools" tests label Jul 9, 2025
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@neilcsmith-net neilcsmith-net merged commit f95f50c into apache:master Jul 15, 2025
33 checks passed
@cstamas
Copy link
Member

cstamas commented Jul 15, 2025

Context: warning was added by Milos for sonatype plugin as it was heavily rewriting the effective model for itself to "take over" deploy. Hence eff model != actually used model by maven, and it was deemed dangerous.

None of Maveniverse extension touches the model, as they do not meddle with user build.

Still, adding some ability to user to override is IMHO a good idea

@neilcsmith-net
Copy link
Member Author

@cstamas except assuming that was org.sonatype.nexus.maven.staging.deploy.DeployLifecycleParticipant(?) we were ignoring that and not warning already! We should probably reverse the warning logic here. And not necessary once we get to Maven 4 anyway??

@cstamas
Copy link
Member

cstamas commented Jul 15, 2025

🌴

But also new sonatype ext (that does same thing) is not listed either. And yes, makes sense.

@neilcsmith-net
Copy link
Member Author

Yes, but now people will have to switch to Njord if they don't want warnings on their projects! 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maven [ci] enable "build tools" tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants