Not sure what @dbalek thinks here, but thinking of this for a bit: I am not sure that forcing the same list of commit characters on all completion items is ideal. E.g. there may be some items where it may make sense to confirm them on (, while some not, and that is not possible to do with a single list.

Maybe one of these would work better:

• have a boolean switch that would enable/disable the commit characters that the provider filled in. I.e. if enabled, whatever commit character that the provider filled in the item would be used; if disabled, none would be used.
• have a setting with permitted commit characters. I.e. the real commit characters in an item would be the intersection between this setting and the characters from the provider. (Or, the setting could be a deny list - i.e. the characters in the list would be removed from every item's commit characters.)

Going back to this - thinking of this more, the actual commit characters sent out from the server should probably be an intersection between the commit characters requested by the completion item, and the user-selected commit characters. That would make most sense to me.

Going back to this - thinking of this more, the actual commit characters sent out from the server should probably be an intersection between the commit characters requested by the completion item, and the user-selected commit characters. That would make most sense to me.

Yes, this approach would be better, however even in NetBeans, all JavaCompletionItems currently share the same list of commit characters (even though the API would allow more fine grained approach). Would be a nice enhancement.

I was digging a little bit more on how this works in NetBeans, and it turns out that whatever is in the settings is used unconditionally for all completion items, except for ( for a very specific list of completion items (MethodItem, etc.).

So, ultimately, we can go with the patch as proposed here, I think.

FWIW, the existing filter is here:

Unless there are objections, I would like to integrate in a few days.