support for media query level 4 #8013#8409
Conversation
33acb03 to
6ee3cdc
Compare
6ee3cdc to
9119ed0
Compare
I suggest to see if it would make sense to follow the names from the CSS4 document: https://drafts.csswg.org/mediaqueries/#mq-syntax. That grammar might also give a hint what needs to be supported and might enable a complete implementation. |
Ah yes, at a first glance from this perspective I think |
fd0eaed to
509c382
Compare
|
I've updated the naming.
There is a "hack" though for cp_css files in which the condition : was used to fix the greedy sass expression in : The |
02d71dc to
2114e72
Compare
|
I see that I will have to revert some updates from NodeType for compatiblity reason. |
2114e72 to
668601f
Compare
|
@haidubogdan yeah these things have the tendency to be the proverbial can of worms. Could you give me an insight whether you need/want help and if so, where or what is the current state? |
|
Thank you @matthiasblaesing, for the moment it should be ok. |
|
@haidubogdan maybe helpful for you. The |
43c1af6 to
25399cf
Compare
|
@matthiasblaesing I hope that the latest commit will pass the tests. At the current stage there are no additional nodeType tests for the new range syntax, just the parser tests. |
… negation expression for media query Closes: apache#8013
25399cf to
cc2611b
Compare
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me. Unless the CI/CD run yields errors, I'll merge sometime today.
We'll need to have a look at the structure scanner and the model classes in light of newer developments in CSS. The match nested structures and new features badly, but that is another discussion.
Thank you.


This is a pull request to fix parser error warnings on some css media query level 4 syntax. (issue #8013)
This will include changes on antlr parser file, the css parser node structure.
Still not sure about the naming of the new parser rules.
Before:
After:
Includes syntax recognition for
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)