Fix wrong BitSet result in MemoryAccountingBitsetCollector#15656
Open
gaobinlong wants to merge 4 commits intoapache:mainfrom
Open
Fix wrong BitSet result in MemoryAccountingBitsetCollector#15656gaobinlong wants to merge 4 commits intoapache:mainfrom
gaobinlong wants to merge 4 commits intoapache:mainfrom
Conversation
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
epotyom
reviewed
Feb 2, 2026
| return ScoreMode.COMPLETE_NO_SCORES; | ||
| } | ||
|
|
||
| public FixedBitSet getBitSet() { |
Contributor
There was a problem hiding this comment.
Should this be package-private instead? Seems like it's only used for testing.
Contributor
Author
There was a problem hiding this comment.
We need to expose a public method for the upstream caller to get the collected result, but at second thought, this can be implemented in a collector manager for this collector, so we don't need to add a public method here, and the bitSet variable is protected, so we can access it directly in the test method. Thanks!
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
epotyom
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15655, add a test method to verify the BitSet result.