Repository navigation
Fragment large TsBlocks of query result responses between java session and server - #19263
Open
Wei-hao-Li wants to merge 9 commits into
Open
Wei-hao-Li wants to merge 9 commits into
Wei-hao-Li wants to merge 9 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #19263 +/- ##
============================================
+ Coverage 49.22% 49.24% +0.02%
- Complexity 717 718 +1
============================================
Files 5646 5648 +2
Lines 416368 416693 +325
Branches 54966 55011 +45
============================================
+ Hits 204959 205216 +257
- Misses 211409 211477 +68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JackieTien97
requested changes
Nov 16, 2026
JackieTien97
left a comment
Contributor
There was a problem hiding this comment.
Please address the memory accounting and read-size quota regressions introduced by fragmentation, and apply the payload limit to the Fast LAST cache-hit paths. The inline comments describe the affected paths.
…d quota by whole blocks - SharedTsBlockQueue.remove(retainMemory) keeps the reservation of a block that outlives the RPC in PendingResultFragment; freeRetainedMemory() releases it and close/abort free the buffered and handed-over memory together. - LocalSourceHandle delegates the retain/release to its queue, so single-node deployments keep fragmented transfers accounted in the memory pool. - OperationQuota only exposes addReadResult(long bytes); responses charge a block whose fragmentation starts in them by its totalLength, so a fragmented result is charged exactly once against the read quota.
…result The cache-hit branches of executeFastLastDataQueryForOneDeviceV2 and executeFastLastDataQueryForOnePrefixPath serialized the whole result into one response, so an oversized cached value could still exceed the Thrift frame limit. The cached result is now registered as a MaterializedResultExecution and sent through the regular fragmented transfer: fetchResultsV2 continues from its pending fragment, and the serialized bytes are reserved from the query memory pool (best effort) until the last fragment is sent or the query is cleaned up.
Conflicts in i18n message classes are additive; kept the constants from both sides (fragmented query result messages and the incoming buffer/frame-size messages).
respondWithFragmentedResult is only entered when the cached result exceeds the payload bound, so the materialized transfer always starts with a fragment; replace the defensive finish branch with checkState.
Conflicts in the JDBC result-set construction: keep the upstream resource cleanup (close the query operation when result-set creation fails) together with the offset/totalLength arguments added for fragmented results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




No description provided.