Skip to content

Conversation

@gunli
Copy link
Contributor

@gunli gunli commented Jul 29, 2025

Fixes #11954

Motivation

Fix potential data race in Golang SDK

Modifications

  1. Handle all the IO errors;
  2. Disard connection's ring buffer after handling the response;
  3. Fix lint error in id.go by the way.

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

@dockerzhang dockerzhang merged commit 19464a3 into apache:master Jul 30, 2025
6 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][SDK] Potential data race in Golang SDK

4 participants