Repository navigation
Conversation
Give the parser names for scalar and list literals so missing values report what is expected.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
An incomplete row filter such as
id =orid IN ()currently reports a long list of parser alternatives. Name the two literal expressions so those inputs reportExpected a literal valueandExpected a non-empty list of literals, respectively.This addresses the parser error-message portion of #2860.
Are these changes tested?
Both new regression cases fail on the base commit and pass with this change. All 46 parser tests pass.
make testpassed with 4,752 tests passing and 5 skipped, andmake lintpassed.Are there any user-facing changes?
Error messages for missing scalar literals and empty literal lists are clearer. Valid filters parse as before.
AI assistance
An AI assistant helped reproduce the parser errors, identify where to name the literal expressions, and write and run the regression tests.