Skip to content

Clarify missing literal errors in row filters - #4416

Open
linzch3 wants to merge 1 commit into
apache:mainfrom
linzch3:codex/filter-parser-errors
Open

linzch3 wants to merge 1 commit into
apache:mainfrom
linzch3:codex/filter-parser-errors

Conversation

@linzch3

@linzch3 linzch3 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

An incomplete row filter such as id = or id IN () currently reports a long list of parser alternatives. Name the two literal expressions so those inputs report Expected a literal value and Expected a non-empty list of literals, respectively.

This addresses the parser error-message portion of #2860.

Are these changes tested?

Both new regression cases fail on the base commit and pass with this change. All 46 parser tests pass. make test passed with 4,752 tests passing and 5 skipped, and make lint passed.

Are there any user-facing changes?

Error messages for missing scalar literals and empty literal lists are clearer. Valid filters parse as before.

AI assistance

An AI assistant helped reproduce the parser errors, identify where to name the literal expressions, and write and run the regression tests.

Give the parser names for scalar and list literals so missing values report what is expected.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant