Repository navigation
Fix the BigQuery namespace-exists error message - #4415
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The message was a plain string, so it showed the literal
"{database_name}" instead of the namespace name. Make it an f-string
and add a test for create_namespace on an existing dataset.
ebyhr
approved these changes
Nov 18, 2026
ebyhr
left a comment
Member
There was a problem hiding this comment.
LGTM. I confirmed the new test fails without the fix and passes with it. I also checked the rest of pyiceberg/ for the same mistake and found no other instances.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In the BigQuery catalog, the "namespace already exists" error shows "{database_name}" literally. The string is missing the f prefix. Now it shows the real namespace name.
Are these changes tested?
I added a test with a mocked client that raises Conflict.
Are there any user-facing changes?
The error message now shows the real namespace name.
AI disclosure: an AI assistant (Claude) found the bug and wrote the fix and the test. The diff was reviewed by the assistant on my behalf; I have not run the change myself.