Skip to content

Update NameMapping on update_schema()#441

Merged
Fokko merged 6 commits intoapache:mainfrom
sungwy:update-mapping
Feb 20, 2024
Merged

Update NameMapping on update_schema()#441
Fokko merged 6 commits intoapache:mainfrom
sungwy:update-mapping

Conversation

@sungwy
Copy link
Copy Markdown
Collaborator

@sungwy sungwy commented Feb 18, 2024

Similar to the Java implementation, we should update the existing name_mapping on update_schema().

Some changes:

  • Table.name_mapping no longer defaults to the auto-generated name_mapping based on the current Schema. We should explicitly return None if the property isn't set, so that we can use the function return value to avoid the additional steps in updating the existing name mapping.
  • I've introduced some changes compared to the Java version. Specifically:

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants