Repository navigation
fix(expressions): reject fractional strings converting to int/long #4383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Fokko
merged 8 commits into
apache:main
from
Shahzeb-DataEngineer:issue-string-literal-fractional-truncate
Nov 18, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d5c4511
fix(expressions): reject fractional strings converting to int/long
Shahzeb-DataEngineer 9d93982
test(expressions): expect ValueError for fractional strings to int/long
Shahzeb-DataEngineer 316f3b6
style: remove stray blank line in test_string_literal
Shahzeb-DataEngineer d3c2330
fix: restore closing parentheses on pi_double_lit
Shahzeb-DataEngineer f1a439f
fix: correct indentation of sqrt2 assert in test_string_literal
Shahzeb-DataEngineer 66057bd
fix: dedent test_integral_decimal_to_integral_type to top level
Shahzeb-DataEngineer 472b861
fix(expressions): check fractional part before range check in StringL…
Shahzeb-DataEngineer f01648a
test: cover integral string to int/long happy flow in test_string_lit…
Shahzeb-DataEngineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still want to test the happy flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done. I restored the happy-flow asserts in test_string_literal: literal("3").to(IntegerType()) and literal("3").to(LongType()) both equal literal(3). The fractional cases still raise as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you 👍