Skip to content

Row lineage: Preserve first_row_id from REST scan planning - #4352

Merged
Fokko merged 1 commit into
apache:mainfrom
rambleraptor:rest-scan-planning-first-row-id
Nov 13, 2026
Merged

Fokko merged 1 commit into
apache:mainfrom
rambleraptor:rest-scan-planning-first-row-id

Conversation

@rambleraptor

Copy link
Copy Markdown
Collaborator

Rationale for this change

The REST data file model parses first-row-id, but it was dropped when converting to a DataFile, so planned scans lost row lineage info.

This is one of a handful of PRs I'll be pushing out to finish up row lineage support. We have to plumb it through (and verify it) in a handful of places.

Are these changes tested?

Included a unit test

Are there any user-facing changes?

The REST data file model parses first-row-id, but it was dropped when
converting to a DataFile, so planned scans lost row lineage info.

Part of apache#4080.
@rambleraptor
rambleraptor requested a review from Fokko November 12, 2026 20:10
@rambleraptor rambleraptor changed the title Preserve first_row_id from REST scan planning Row lineage: Preserve first_row_id from REST scan planning Nov 12, 2026

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rambleraptor! 🚀 Verified against the REST spec (first-row-id is optional int64 on DataFile only) and the tests pass, LGTM!

@Fokko
Fokko added this pull request to the merge queue Nov 13, 2026
Merged via the queue into apache:main with commit 5d043a2 Nov 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants