Skip to content

Tests: Cover schema changes and appends during commit retry - #4024

Open
mifuha wants to merge 2 commits into
apache:mainfrom
mifuha:test/schema-append-commit-retry
Open

mifuha wants to merge 2 commits into
apache:mainfrom
mifuha:test/schema-append-commit-retry

Conversation

@mifuha

@mifuha mifuha commented Sep 27, 2026 •

Copy link
Copy Markdown

Rationale for this change

Add a test for a transaction that adds a nullable column and appends a row, while another writer commits first.

The test checks that the first writer retries and keeps the new column, its field ID, and all three rows. It also checks the snapshot's parent and schema ID, and that reloading the table gives the same result.

Are these changes tested?

After updating from main on 4 November, local validation on Python 3.12 passed: 4,479 tests passed, 5 skipped and 129 deselected. make lint also passed. All eight GitHub CI workflows passed, including integration tests and documentation.

Are there any user-facing changes?

No. This adds test coverage only.

AI-assisted implementation.

@mifuha

mifuha commented Nov 18, 2026

Copy link
Copy Markdown
Author

Hi @rambleraptor, would you have time to review this test covering schema changes and appends during commit retry? All CI checks now pass. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant