Fail when explicitly deleted data file is missing - #3818
Open
rambleraptor wants to merge 1 commit into
Open
Conversation
rambleraptor
force-pushed
the
pr-3814
branch
2 times, most recently
from
August 21, 2026 19:27
49d7ef9 to
ae10cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #3814
This looks like the problem I pointed out in #3811 but didn't explain properly enough. We should look for all explicitly deleted files and make sure they exist. This matches how Java handles the situation.
Are these changes tested?
Included unit tests based off the issue's verification script
Are there any user-facing changes?