Skip to content

Implement Hive catalog _commit_table - #294

Merged
Fokko merged 2 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/hive-catalog-commit
Jan 22, 2024
Merged

Fokko merged 2 commits into
apache:mainfrom
kevinjqliu:kevinjqliu/hive-catalog-commit

Conversation

@kevinjqliu

@kevinjqliu kevinjqliu commented Jan 22, 2024 •

Copy link
Copy Markdown
Contributor

Comment thread pyiceberg/catalog/hive.py
PROP_TABLE_TYPE = "table_type"
PROP_METADATA_LOCATION = "metadata_location"
PROP_PREVIOUS_METADATA_LOCATION = "previous_metadata_location"
DEFAULT_PROPERTIES = {'write.parquet.compression-codec': 'zstd'}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only want to set this when writing Parquet, but that's the only format that we support today :)

@Fokko
Fokko merged commit acfa5bc into apache:main Jan 22, 2024
@Fokko

Fokko commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Thanks for working on this @kevinjqliu 🙌

@kevinjqliu
kevinjqliu deleted the kevinjqliu/hive-catalog-commit branch January 22, 2024 16:54
@HonahX HonahX mentioned this pull request Feb 5, 2024
@Fokko Fokko changed the title implement hive catalog _commit_table Implement Hive catalog _commit_table Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants