Skip to content

Use Iceberg-Rust for parsing the ManifestList and Manifests#2004

Closed
Fokko wants to merge 78 commits intoapache:mainfrom
Fokko:fd-rust
Closed

Use Iceberg-Rust for parsing the ManifestList and Manifests#2004
Fokko wants to merge 78 commits intoapache:mainfrom
Fokko:fd-rust

Conversation

@Fokko
Copy link
Copy Markdown
Contributor

@Fokko Fokko commented May 14, 2025

Rationale for this change

This replaces the Cython implementation for reading Avro with Iceberg-Rust. This would greatly simplify the PyIceberg project since we don't have to publish Python wheels anymore.

Are these changes tested?

Are there any user-facing changes?

@Fokko Fokko changed the title Fd rust Use Iceberg-Rust for parsing the ManifestList and Manifests May 15, 2025
@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Jun 26, 2025

@roeap Thanks, your patch fixed correctly passing through the 102: partition field 🥳

Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we're waiting for apache/iceberg-rust#1328 to finalize, which is dependent on apache/iceberg-rust#1482 :)

@yogevyuval
Copy link
Copy Markdown

@Fokko This is awesome! thanks for your work on this one.
Do we expect any performance/memory differences with reading it with the rust module?

@Fokko
Copy link
Copy Markdown
Contributor Author

Fokko commented Jul 8, 2025

@yogevyuval Thanks for asking, and yes, I do expect performance impact since just a part of the deserialization is cythonized. With this change, much more is pushed into Rust. This will also reduce the GIL pressure since we don't have to build the readers anymore :)

I left this PR small to focus on the essentials, but once this is in, we can also clean up a LOT of code 👍

@yogevyuval
Copy link
Copy Markdown

@yogevyuval Thanks for asking, and yes, I do expect performance impact since just a part of the deserialization is cythonized. With this change, much more is pushed into Rust. This will also reduce the GIL pressure since we don't have to build the readers anymore :)

I left this PR small to focus on the essentials, but once this is in, we can also clean up a LOT of code 👍

Interesting, we have quite a bit of concurrency going on so curious to see the results. Once apache/iceberg-rust#1328 gets merged and release i'll try and create some basic benchmarks and share the results

@kevinjqliu kevinjqliu added this to the PyIceberg 0.11.0 milestone Jan 20, 2026
@kevinjqliu kevinjqliu removed this from the PyIceberg 0.11.0 milestone Jan 23, 2026
@geruh geruh mentioned this pull request Jan 30, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 17, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants