Suggestions for #1033#1218
Closed
edgarrmondragon wants to merge 18 commits intoapache:mainfrom
edgarrmondragon:1033-suggestions
Closed
Suggestions for #1033#1218edgarrmondragon wants to merge 18 commits intoapache:mainfrom edgarrmondragon:1033-suggestions
edgarrmondragon wants to merge 18 commits intoapache:mainfrom
edgarrmondragon:1033-suggestions
Conversation
Contributor
edgarrmondragon
commented
Oct 5, 2024
edgarrmondragon
commented
- s3_signer_endpoint
- prune any trailing whitespaces
- fallback to default value instead of "endpoint" property
- fix test_s3v4_rest_signer_endpoint
- Fix missing backtick
- create access_delegation property
- rename S3_SIGNER_ENDPOINT_DEFAULT_VALUE to S3_SIGNER_ENDPOINT_DEFAULT
- fix s3.signer.endpoint docs
- fk typo in signer
- fix fmt
- rename ACCESS_DELEGATION_DEFAULT_VALUE to ACCESS_DELEGATION_DEFAULT
- rename access_delegation to access-delegation
- fix grammar
- Suggestions for Access delegation #1033
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
Co-authored-by: Sung Yun <107272191+sungwy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.