Conversation
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you add a few more test scenarios?
- Time64Type with
usprecision - Time64Type with
nsprecision,_downcast_ns_timestamp_to_usnot set - Time64Type with
nsprecision,_downcast_ns_timestamp_to_usis set
I also want to make sure that downcast works for "Time64Type with ns precision". So let's add a test on the read/write path to verify this.
|
@kevinjqliu i have a few questions about the these test case scenarios
|
|
You can find some information in my previous PR. |
You can use #848 as an example where timestamp downcast was implemented |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
It would be great to revive this, please |
@kevinjqliu made the changes suggested in the previous comments and added the test case for the functionality