Skip to content

Missing unit tests for human-readable date/time formatters in utils/datetime.py #4387

Closed

Description

@prabhleen2317

Feature Request / Improvement

Several pure helper functions in pyiceberg/utils/datetime.py have no unit
test coverage in tests/utils/test_datetime.py:

  • to_human_year
  • to_human_month
  • to_human_day
  • to_human_hour
  • to_human_time
  • to_human_timestamp
  • to_human_timestamptz
  • micros_to_days
  • days_to_date

These are deterministic input→output functions, so they are straightforward
to cover with unit tests. Adding tests guards against regressions in the
human-readable formatting used by the CLI and __repr__ output.

I'd like to work on this and submit a PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions