Open
Conversation
mapleFU
reviewed
Feb 6, 2026
| ninja==1.13.0 | ||
| mkdocs==1.6.1 | ||
| mkdocs-material==9.6.22 | ||
| pre-commit==4.5.1 |
Author
|
No. But this requires only a single line change. it's currently missing this dependency, so I combined two changes together.
---- Replied Message ----
| From | ***@***.***> |
| Date | 02/06/2026 11:27 |
| To | apache/iceberg-cpp ***@***.***> |
| Cc | 姚军 ***@***.***>,
Author ***@***.***> |
| Subject | Re: [apache/iceberg-cpp] fix: use std::move when pass by value (PR #555) |
@mapleFU commented on this pull request.
In requirements.txt:
@@ -2,3 +2,4 @@ meson==1.3.0
ninja==1.13.0
mkdocs==1.6.1
mkdocs-material==9.6.22
+pre-commit==4.5.1
Is this related?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
HuaHuaY
reviewed
Feb 6, 2026
| template <typename R, typename... Args> | ||
| struct Trait<R (*)(Args...)> { | ||
| using ReturnType = R::value_type; | ||
| using ReturnType = typename R::value_type; |
Contributor
There was a problem hiding this comment.
Is this a warning from clang-tidy? I guess that typename may be duplicate here.
Author
There was a problem hiding this comment.
Yes, clang-tidy suggest that. I think it is more straightforward if added.
Contributor
There was a problem hiding this comment.
According to cppreference(https://en.cppreference.com/w/cpp/language/dependent_name.html), a dependent qualified name is assumed to name a type and no typename is required when a qualified name that appears in type-id, where the smallest enclosing type-id is the type-id in an alias declaration since C++20. Can you show the rule name when you meet clang-tidy warning?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi iceberg-cpp team, I found a clang-tidy warning on my environment.