[FLINK-40597][core] Fix input type validation for Types.UUID - #29133
Merged
Conversation
dylanhz
marked this pull request as ready for review
September 8, 2026 16:05
dylanhz
force-pushed
the
codex/fix-uuid-type-validation
branch
2 times, most recently
from
September 9, 2026 09:03
3936022 to
e0c0526
Compare
Generated-by: Codex 0.147.0 (model: gpt-6)
dylanhz
force-pushed
the
codex/fix-uuid-type-validation
branch
from
September 9, 2026 11:38
e0c0526 to
ccfe431
Compare
raminqaf
reviewed
Sep 11, 2026
Comment on lines
+844
to
+850
| final MapFunction<UUID, String> mapper = | ||
| new MapFunction<UUID, String>() { | ||
| @Override | ||
| public String map(UUID value) { | ||
| return value.toString(); | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
Can the MapFunction return the UUID type as byte[] or Byte? Let's add a test like this
@Test
void testMapToBytesWithExplicitUuidType() {
final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
// A lambda would bypass the input validation exercised by this test.
final MapFunction<UUID, byte[]> byteMapper = value -> {
ByteBuffer buffer = ByteBuffer.wrap(new byte[16]);
buffer.putLong(value.getMostSignificantBits());
buffer.putLong(value.getLeastSignificantBits());
return buffer.array();
};
final DataStream<byte[]> stream = env.fromData(Types.UUID, new UUID(0L, 0L)).map(byteMapper);
assertThat(stream.getType()).isEqualTo(PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO);
}
Contributor
There was a problem hiding this comment.
Or even having a test for Mapping String -> UUID
Contributor
Author
There was a problem hiding this comment.
UUID → byte[] seems to exercise the same input validation as UUID → String, while String → UUID covers output extraction. Is there a specific scenario you’d like these tests to cover?
raminqaf
reviewed
Sep 11, 2026
Comment on lines
+1507
to
+1510
| final TypeInformation<?> actual = | ||
| type == UUID.class | ||
| ? BasicTypeInfo.UUID_TYPE_INFO | ||
| : BasicTypeInfo.getInfoFor((Class<?>) type); |
Contributor
There was a problem hiding this comment.
Should we add a test in TypeExtractorTest?
Contributor
Author
There was a problem hiding this comment.
Agreed. Moved both tests to TypeExtractorTest.
github-actions
Bot
added
the
community-reviewed
Generated-by: Codex 0.147.0 (model: gpt-6)
dylanhz
force-pushed
the
codex/fix-uuid-type-validation
branch
from
September 14, 2026 07:35
b2d9415 to
792f7a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix FLINK-40597: a DataStream created with explicit
Types.UUIDcan fail input type validation for a non-lambdaMapFunction<UUID, String>withInput mismatch: Basic type expected.Brief change log
java.util.UUIDwhen validating explicitly specified basic type information.GenericTypeInfo<UUID>with Kryo by default). Automatic extraction asTypes.UUIDis tracked separately in FLINK-40546.Verifying this change
fromData(Types.UUID, ...).map(...)regression test and a check thatfromData(...)still infersGenericTypeInfo<UUID>.DataStreamTestandTypeExtractorTest: 102 tests passed after rebasing onto master../mvnw clean verifywas attempted. After resolving a local Python executable issue and resuming, verification stopped atflink-s3-fs-base:SeaweedFsTestContainerTestrequires Docker, which is not installed locally. Subsequent modules have not been verified.Does this pull request potentially affect one of the following parts:
@PublicTypeExtractor; no API signatures changeDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Codex 0.147.0 (model: gpt-6)