FLINK-37686 - Do not fail on NOT_OWNED deleted files#28801
Open
francis-a wants to merge 1 commit into
Open
Conversation
Collaborator
Contributor
|
@francis-a Thanks for the PR. LGTM. The orphan files deleted by the JM are abandoned by ForSt. They should be removed and not cause failures during a full scan. @Zakelly Could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR aims to fix the issue documented in https://issues.apache.org/jira/browse/FLINK-37686 where remote objects cleaned up by the JM cause checkpoint failures even when the object is marked as
NOT_OWNED.Brief change log
FileNotFoundExceptioncatch block toForStFlinkFileSystem::listStatusNOT_OWNEDFileMappingManagerNOT_OWNEDVerifying this change
This change added tests and can be verified as follows:
ForStFlinkFileSystemTest,testListStatusDropsDeletedNotOwnedEntryAfterGiveUpOwnershipandtestListStatusStillFailsForDeletedDbOwnedFileNOT_OWNEDand verify the removed object is also removed from theFileMappingManager, the other test verifies the baseline hasn't changed for other object typesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude Opus]