Upgrade Avro Dependency to 1.12.1#27836
Draft
danielrod08 wants to merge 2 commits intoapache:masterfrom
Draft
Conversation
Collaborator
mxm
reviewed
Mar 27, 2026
Contributor
mxm
left a comment
mxm
left a comment
There was a problem hiding this comment.
Thanks @danielrod08! Is this an API-only change which will not impact the wire format?
| .setTypeDecimalFixed( | ||
| new Fixed2(BigDecimal.valueOf(2000, 2).unscaledValue().toByteArray())) | ||
| .setTypeDecimalBytes(BigDecimal.valueOf(2000, 2)) | ||
| .setTypeDecimalFixed(BigDecimal.valueOf(2000, 2)) |
Contributor
There was a problem hiding this comment.
Not sure how this can work, why are we omitting Fixed2?
Comment on lines
+202
to
+204
| user.setTypeDecimalBytes(BigDecimal.valueOf(2000, 2)); | ||
| // 20.00 | ||
| user.setTypeDecimalFixed( | ||
| new Fixed2(BigDecimal.valueOf(2000, 2).unscaledValue().toByteArray())); | ||
| user.setTypeDecimalFixed(BigDecimal.valueOf(2000, 2)); |
Contributor
There was a problem hiding this comment.
Why does the change affect both bytes and fixed type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request upgrades the Apache Avro dependency from version 1.11.4 to 1.12.1 in order to support nanosecond-precision (as described in this PR #27770).
Brief change log
pom.xmland NOTICE files to upgrade the Avro VersionVerifying this change
This change is a trivial version upgrade.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation