fix: support immutable lists in dynamic header #668
Conversation
This prevents UnsupportedOperationException when using immutable lists such as Arrays.asList、List.of or Collections.unmodifiableList ...
|
|
||
| Assertions.assertEquals(1, list.size()); | ||
| Map<Integer, String> data = list.get(0); | ||
| Assertions.assertEquals("字符串0", data.get(0)); |
|
|
||
| import java.io.File; | ||
| import java.text.ParseException; | ||
| import java.util.*; |
- Use English to describe - Avoid use imports *
|
Thanks for the review. I’ve updated the test code as suggested. |
I considered another approach in #665: In
So I decided not to adopt that solution. |
| if (null == head || head.isEmpty()) { | ||
| return head; | ||
| } | ||
| return head.stream().map(ArrayList::new).collect(Collectors.toList()); |
There was a problem hiding this comment.
why not directly new ArrayList as no any map or reduce required?
There was a problem hiding this comment.
I’ve replaced the previous stream implementation with a simple for loop to create the copy. I also updated the method description: changed "fully mutable deep copy ..." to "fully mutable of head list" which more accurately reflects the actual behavior.
3 participants
Purpose of the pull request
Fixed: #665
Avoid
UnsupportedOperationExceptionwhen using immutable list (such as:Arrays.asList、List.oforCollections.unmodifiableList...) in dynamic headerWhat's changed?
AbstractParameterBuilder#headto always convertheadinto a mutable deep copy, preventingUnsupportedOperationExceptionwith immutable lists.ImmutableListHeadDataTest).Checklist