Skip to content

provide ILIKE support - #300

Merged
maxcountryman merged 1 commit into
apache:mainfrom
maxcountryman:feature/ilike
Mar 22, 2021
Merged

maxcountryman merged 1 commit into
apache:mainfrom
maxcountryman:feature/ilike

Conversation

@maxcountryman

Copy link
Copy Markdown
Contributor

This introduces support for ILIKE and NOT ILIKE. ILIKE is the
case-insensitive variant of LIKE. Systems such as Postgres, Redshift,
and Snowflake provide this variant.[1][2][3]

[1] https://www.postgresql.org/docs/7.3/functions-matching.html
[2] https://docs.aws.amazon.com/redshift/latest/dg/r_patternmatching_condition_like.html
[3] https://docs.snowflake.com/en/sql-reference/functions/ilike.html

@maxcountryman
maxcountryman requested a review from Dandandan March 20, 2021 15:58
@coveralls

coveralls commented Mar 20, 2021

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 676366782

  • 33 of 36 (91.67%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 90.054%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 0 1 0.0%
src/parser.rs 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 86.11%
Totals Coverage Status
Change from base Build 674150113: 0.008%
Covered Lines: 5460
Relevant Lines: 6063

💛 - Coveralls

@maxcountryman

Copy link
Copy Markdown
Contributor Author

This lint issue seems to also happen on main.

@Dandandan

Copy link
Copy Markdown
Contributor

looks good! could you merge/rebase to get in the clippy lint fixes?

This introduces support for ILIKE and NOT ILIKE. ILIKE is the
case-insensitive variant of LIKE. Systems such as Postgres, Redshift,
and Snowflake provide this variant.[1][2][3]

[1] https://www.postgresql.org/docs/7.3/functions-matching.html
[2] https://docs.aws.amazon.com/redshift/latest/dg/r_patternmatching_condition_like.html
[3] https://docs.snowflake.com/en/sql-reference/functions/ilike.html
@maxcountryman
maxcountryman merged commit 35ef0ee into apache:main Mar 22, 2021
@maxcountryman
maxcountryman deleted the feature/ilike branch March 22, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants