Skip to content

Parse floats without leading number - #294

Merged
Dandandan merged 5 commits into
apache:mainfrom
Dandandan:parse_floats
Feb 8, 2021
Merged

Dandandan merged 5 commits into
apache:mainfrom
Dandandan:parse_floats

Conversation

@Dandandan

Copy link
Copy Markdown
Contributor

This fixes parsing TCPH query 6 (.01)

@andygrove

@coveralls

coveralls commented Feb 7, 2021

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 545488520

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 90.091%

Files with Coverage Reduction New Missed Lines %
src/parser.rs 1 85.88%
src/tokenizer.rs 1 91.83%
Totals Coverage Status
Change from base Build 538263797: 0.006%
Covered Lines: 5337
Relevant Lines: 5924

💛 - Coveralls

@andygrove andygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove

Copy link
Copy Markdown
Member

@Dandandan needs rebase

@Dandandan

Copy link
Copy Markdown
Contributor Author

@andygrove fixed

@Dandandan
Dandandan merged commit f40955e into apache:main Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants