Skip to content

fix: serialise native handle lifetime against concurrent close #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andygrove wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: serialise native handle lifetime against concurrent close #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,10 @@ try (var allocator = new RootAllocator();
}
```

`SessionContext` and `DataFrame` are `AutoCloseable` and not thread-safe.
`SessionContext` and `DataFrame` are `AutoCloseable` and safe to share
across threads: `close()` waits for calls already in flight to return
before releasing the native object, and a call that loses the race to a
`close()` throws `IllegalStateException`.

## Documentation

Expand Down
Loading
Loading