Repository navigation
fix: spill final hash aggregate output when the pool refuses it - #26734
Draft
yashaggarwal85d wants to merge 1 commit into
Draft
yashaggarwal85d wants to merge 1 commit into
yashaggarwal85d wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
FinalHashAggregateStreamfails withResourcesExhaustedwhen the materialized output is bigger than the table it came from (e.g.string_agg) and the pool won't grow the reservation. The other streams carry on.What changes are included in this PR?
When that resize is refused and temp files are enabled, the stream writes the materialized output to one spill file, drops it, frees the reservation and streams the batches back. Without temp files it still errors, now with a message saying it couldn't spill the output.
What is the testing strategy for this PR?
Updated the
Finalcase inoutput_materialization_refused(from #26562): it now spills once and returns all 256 rows in 4 batches. Aggregate unit tests and the aggregate slt files pass.Are there any user-facing changes?
No, queries that hit this now succeed instead of erroring.
This was AI-assisted, I've reviewed the changes myself.